Skip to content

Conversation

CartonPoete
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

Using angular-token with rails devise auth + apartment, so my subdomain (tenant) from the apiBase might change
In order to dynamically change the subdomain, I've added a getter and setter for angularTokenOptions

Copy link
Owner

@neroniaky neroniaky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you use getter and setter functions? And I think it would be easier to just return the entire options object because we can use typings then.

@yashrs
Copy link

yashrs commented Jan 7, 2019

Any update to this? It would be a good addition!

@neroniaky neroniaky merged commit 4270e9e into neroniaky:master Jan 9, 2019
@neroniaky
Copy link
Owner

Thank you!

neroniaky added a commit that referenced this pull request Jun 19, 2022
* Add getter and setter for AngularTokenOptions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants