Work for satisfy recent Composer versions and a couple of features #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
April 16, 2019 12:00
…Interface only defines a sub-set of operations needed by neronmoon/scriptsdev and RootAliasPackage only implemented those methods defined by the interface. Most of the unimplemented methods in RootAliasPackage can be worked around because the getter methods that are implemented proxy to the aliased package which we can modify by unwrapping.
- Bugfix to skip warning about previous commands existence. - Read/writes JSON composer way (adopted from `composer/satis`) - Some refactor and minor improvements. * Features to be tested: - Remove duplicates by `scripts-dev-replace` key (adopted from `wikimedia/composer-merge-plugin`). - Remote merging by `scripts-dev-remote` (adopted from `composer/satis`, theoretically have precedence `scripts-dev` versus `scripts-dev-remote`, and theoretically only works when `scripts-dev` is missing while `scripts-dev-remote` no)
ghost
changed the title
added 3 commits
April 18, 2019 15:28
Strange behaviour with `legacy-with-run-scripts-dev` test: ---------------------------------------------------- legacy-with-run-scripts-dev [['composer', 'update'], ['composer', '--no-dev', 'run-script', 'test']] ---------------------- outputs --------------------- Exception: EXPECTED "SCRIPTSDEV RULEZ" BUT FOUND "SCRIPTSDEV RULEZ" -------------------
ghost
mentioned this pull request
added 8 commits
April 19, 2019 02:45
…th builtin composer + symlinking path, and makes running tests ultra-fast.
With the gone previous behaviour another wrong one comes out, this time with `extra-with-custom-script-run-script-dev` test: ---------------------------------------------------- Testing: extra-with-custom-script-run-script-dev [['composer', 'update'], ['composer', 'test']] ---------------------- outputs --------------------- Exception: EXPECTED "SCRIPTSDEV RULEZ" BUT FOUND "" ------------------------------͌ I seems its working with `post-install-cmd` or `post-update-cmd` commands but with the `test` command? Maybe Seldaek@599ad77167bc8cee895f024a20292689fd84153f can help somehow?
Added static analysis tool. Needs more tests.
Added static analysis tool. Needs more tests.
Added static analysis tool. Needs more tests.
|
Thank you for your work! Thank you |
Hello @neronmoon. I know have added some geeky dependencies, there are some fancy messages too, have a workaround with all current tests ok and will remove those unnecessary user-dependencies, but there are some "generification" in code that don't know if you like it. Wants ready to merge/replace any section almost in same way that did before (plus remote support), but doing just for scripts if no extends. You are welcome. Kind regards. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Composer versions before composer/composer@599ad77 the RootPackageInterface only defines a sub-set of operations needed by neronmoon/scriptsdev and RootAliasPackage only implemented those methods defined by the interface. Most of the unimplemented methods in RootAliasPackage can be worked around because the getter methods that are implemented proxy to the aliased package which we can modify by unwrapping.