Fixed host parsing to work with ipv6 addresses #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, can you please add a test for this? |
|
The test should be something like: ssh [2001:DB8::1234]:22 I guess? |
can now put [ ] around the ip address, without this ipv6 addresses that are like 2605:fd00:4:1000:f816:3eff:fe33:4679 would be have '4679' be interpreted as a port number.
|
This was so long ago that it completely fell off my radar. I've added a test for using ipv6 with the bracketed notation. |
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
can now put [ ] around the ip address, without this ipv6 addresses that
are like 2605:fd00:4:1000:f816:3eff:fe33:4679 would be have '4679' be
interpreted as a port number.