Skip to content

Draggable thumb goes off the view #40

@rimzici

Description

@rimzici

Really appreciate the awesome work!!

The issue might be a corner case. Here is a gif of the issue.

ezgif com-video-to-gif

It is understandable that, the draggable thumb is where user must be pressing and dragging. But the pan responder is set on the outer View, so it is very much possible to touch anywhere on the outer view and drag. This actually opens the gateway for the issue.

When the user start dragging from outside, the outBounds method will return true and prevents setting pan value inside onStartShouldSetPanResponderCapture. The outBounds call inside onPanResponderMove also returns true but pageX and pageY has been changing the all way along.

Was wondering if there was any particular reason why the pan responder is set on the outer view, and not the image itself ?

Here is a reproducible demo if you would like to try.

Thanks!

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions