Skip to content

"None" filter selection gets lost on adjustment of filter #15971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ITJamie opened this issue May 6, 2024 · 3 comments · Fixed by #19310
Closed

"None" filter selection gets lost on adjustment of filter #15971

ITJamie opened this issue May 6, 2024 · 3 comments · Fixed by #19310
Assignees
@jeremystretch
Labels
netbox severity: low Does not significantly disrupt application functionality, or a workaround is available status: accepted This issue has been accepted for implementation type: bug A confirmed report of unexpected behavior in the application
Milestone
v4.2.9

Comments

@ITJamie
Copy link
Contributor

ITJamie commented May 6, 2024

Deployment Type

Self-hosted

NetBox Version

v4.0-beta2

Python Version

3.11

Steps to Reproduce

  1. Goto devices
  2. Goto Filters tab
  3. Under Tenant select None and another tenant
  4. Trigger Search
  5. Goto Filters tab
  6. note that the "None" selection is no longer selected under the tenant type. adjusting anything else on the search form will trigger a search without "None" being selected anymore.

Expected Behavior

Filters which can be configured in the UI should not be lost when updating the search params through the ui

Observed Behavior

None filter is lost when updating the filter query through the UI
@ITJamie ITJamie added status: needs triage This issue is awaiting triage by a maintainer type: bug A confirmed report of unexpected behavior in the application labels May 6, 2024
@ITJamie
Copy link
Contributor Author

ITJamie commented May 6, 2024

(note this has been an issue for awhile. it was not introduced as part of the v4 changes)

@jeremystretch jeremystretch removed their assignment May 7, 2024
@jeremystretch jeremystretch added status: needs owner This issue is tentatively accepted pending a volunteer committed to its implementation severity: low Does not significantly disrupt application functionality, or a workaround is available and removed status: needs triage This issue is awaiting triage by a maintainer labels May 7, 2024
@abhi1693 abhi1693 self-assigned this May 9, 2024
@abhi1693 abhi1693 added status: accepted This issue has been accepted for implementation and removed status: needs owner This issue is tentatively accepted pending a volunteer committed to its implementation labels May 9, 2024
@abhi1693 abhi1693 removed their assignment May 9, 2024
@abhi1693 abhi1693 added status: needs owner This issue is tentatively accepted pending a volunteer committed to its implementation and removed status: accepted This issue has been accepted for implementation labels May 9, 2024
@Julio-Oliveira-Encora
Copy link
Contributor

Could you please assign it to me?

@jeremystretch jeremystretch added status: accepted This issue has been accepted for implementation and removed status: needs owner This issue is tentatively accepted pending a volunteer committed to its implementation labels May 14, 2024
@arthanson arthanson added status: needs owner This issue is tentatively accepted pending a volunteer committed to its implementation and removed status: accepted This issue has been accepted for implementation labels Aug 13, 2024
@arthanson arthanson self-assigned this Aug 14, 2024
@arthanson arthanson added status: accepted This issue has been accepted for implementation and removed status: needs owner This issue is tentatively accepted pending a volunteer committed to its implementation labels Aug 14, 2024
@arthanson arthanson added status: needs owner This issue is tentatively accepted pending a volunteer committed to its implementation and removed status: accepted This issue has been accepted for implementation labels Aug 22, 2024
@arthanson arthanson removed their assignment Aug 22, 2024
@jeremystretch jeremystretch added the netbox label Nov 1, 2024 — with Linear
@github-actions GitHub Actions
Copy link
Contributor

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. NetBox is governed by a small group of core maintainers which means not all opened issues may receive direct feedback. Do not attempt to circumvent this process by "bumping" the issue; doing so will result in its immediate closure and you may be barred from participating in any future discussions. Please see our contributing guide.

@github-actions github-actions bot added the pending closure Requires immediate attention to avoid being closed for inactivity label Apr 24, 2025
@jeremystretch jeremystretch self-assigned this Apr 24, 2025
@jeremystretch jeremystretch added status: accepted This issue has been accepted for implementation and removed status: needs owner This issue is tentatively accepted pending a volunteer committed to its implementation pending closure Requires immediate attention to avoid being closed for inactivity labels Apr 24, 2025
jeremystretch added a commit that referenced this issue Apr 24, 2025
@jeremystretch
Fixes #15971: Preserve 'none' selection in filter form fields
47da880
@jeremystretch jeremystretch mentioned this issue Apr 24, 2025
Merged
bctiemann added a commit that referenced this issue Apr 28, 2025
@bctiemann
Merge pull request #19310 from netbox-community/15971-preserve-null-f…
bdef00f 
…ilter

Fixes #15971: Preserve 'none' selection in filter form fields
@jeremystretch jeremystretch added this to the v4.2.9 milestone Apr 28, 2025
@jeremystretch jeremystretch mentioned this issue Apr 30, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jeremystretch jeremystretch

Labels
netbox severity: low Does not significantly disrupt application functionality, or a workaround is available status: accepted This issue has been accepted for implementation type: bug A confirmed report of unexpected behavior in the application
Projects
None yet
Milestone
v4.2.9
Development

Successfully merging a pull request may close this issue.

Fixes #15971: Preserve 'none' selection in filter form fields netbox-community/netbox
5 participants
@arthanson @ITJamie @abhi1693 @jeremystretch @Julio-Oliveira-Encora