Skip to content

Edit and Delete Buttons for mark_populated IPRange on ListView Link to IPAddress Instead of IPRange #19263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
pheus opened this issue Apr 22, 2025 · 1 comment
Assignees
Labels
beta Concerns a bug/feature in a beta release severity: medium Results in substantial degraded or broken functionality for specfic workflows status: accepted This issue has been accepted for implementation type: bug A confirmed report of unexpected behavior in the application

Comments

@pheus
Copy link
Contributor

pheus commented Apr 22, 2025

Deployment Type

Self-hosted

NetBox Version

v4.3.0-beta1

Python Version

3.10

Steps to Reproduce

  1. Create a Prefix 192.168.0.0/22
  2. Create an IP Range 192.168.1.50-99/22 with:
    • Start: 192.168.1.50/22
    • End: 192.168.1.99/22
    • mark_populated: True
  3. Navigate to the Prefix 192.168.0.0/22IP Addresses tab
  4. Locate the row representing the populated IPRange
  5. Click either the Edit or Delete button next to 192.168.1.50-99/22

Expected Behavior

Both Edit and Delete should operate on the IPRange object and bring up the appropriate forms for modifying or deleting the range.

Observed Behavior

Both buttons incorrectly operate on an IPAddress object, using the ID of the IPRange.

Impact:

  • Attempting to edit/delete an IPRange actually opens the form for a different object (an IPAddress).
  • This creates confusion and may result in unintended modifications or deletion of unrelated IPAddresses.

Additional Notes:

  • This seems to affect only populated IPRanges (mark_populated=True).
  • The Edit action is being misrouted, possibly due to a rendering issue or mistaken object type association in the IP Address list view.
@pheus pheus added status: needs triage This issue is awaiting triage by a maintainer type: bug A confirmed report of unexpected behavior in the application labels Apr 22, 2025
@jeremystretch jeremystretch added beta Concerns a bug/feature in a beta release status: needs owner This issue is tentatively accepted pending a volunteer committed to its implementation severity: low Does not significantly disrupt application functionality, or a workaround is available and removed status: needs triage This issue is awaiting triage by a maintainer labels Apr 22, 2025
@arthanson arthanson added status: under review Further discussion is needed to determine this issue's scope and/or implementation status: needs triage This issue is awaiting triage by a maintainer and removed status: needs owner This issue is tentatively accepted pending a volunteer committed to its implementation severity: low Does not significantly disrupt application functionality, or a workaround is available status: needs triage This issue is awaiting triage by a maintainer labels Apr 22, 2025
@pheus pheus changed the title Edit Button for mark_populated IPRange on ListView Links to IPAddress Instead of IPRange Edit and Delete Buttons for mark_populated IPRange on ListView Link to IPAddress Instead of IPRange Apr 22, 2025
@pheus
Copy link
Contributor Author

pheus commented Apr 22, 2025

Update:
This issue also affects the Delete button for populated IP Ranges (mark_populated=True).
Clicking Delete opens the confirmation dialog for an IPAddress object, not the IPRange.

So both Edit and Delete actions are misrouted in the IP Addresses list view when dealing with populated IPRanges.

I've updated the issue title and description to reflect that.
Thanks in advance for taking a look!

@jeremystretch jeremystretch self-assigned this Apr 23, 2025
@jeremystretch jeremystretch added status: accepted This issue has been accepted for implementation severity: medium Results in substantial degraded or broken functionality for specfic workflows and removed status: under review Further discussion is needed to determine this issue's scope and/or implementation labels Apr 23, 2025
jnovinger pushed a commit that referenced this issue Apr 23, 2025
@jnovinger jnovinger added this to the v4.3 milestone Apr 23, 2025
@jnovinger jnovinger removed this from the v4.3 milestone Apr 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beta Concerns a bug/feature in a beta release severity: medium Results in substantial degraded or broken functionality for specfic workflows status: accepted This issue has been accepted for implementation type: bug A confirmed report of unexpected behavior in the application
Projects
None yet
Development

No branches or pull requests

4 participants