-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Return site in circuit-list API #3338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Labels
status: accepted
This issue has been accepted for implementation
type: feature
Introduction of new functionality to the application
Comments
If we're going to go that route, it would probably make more sense to return the whole termination rather than just the assigned site. |
Fair point - I'd considered that but opted for the 'lighter' output. Having the full terminations would definitely have value as well. |
jeremystretch
added a commit
that referenced
this issue
Jan 27, 2020
Fixes #3338: Added termination A and Z to the circuit
jeremystretch
added a commit
that referenced
this issue
Jan 27, 2020
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
status: accepted
This issue has been accepted for implementation
type: feature
Introduction of new functionality to the application
Environment
Proposed Functionality
Add
a_site
andz_site
keys to output of/circuits/circuits
Use Case
In the GUI when viewing the circuit listing, the table has a column that shows the site names for each termination (if it exists). This is extremely useful for filtering by site and generally viewing the circuit list. The API for circuits does not return this matched data however. In order to get the site, you also have to call
/circuits/circuit-terminations/
as well, then pair the data up. This is a slow workflow within a script, and even more-so when trying to represent the data in an external tool.The circuit API does allow you to filter by sites so it would also make it more manageable to know which circuit belongs to which site if you're filtering on multiple sites, without having to do even more API calls.
Database Changes
N/A
External Dependencies
N/A
The text was updated successfully, but these errors were encountered: