Custom link in group does not render Jinja2 code

[rodvand]

Environment

• Python version: 3.6.8
• NetBox version: 2.6.11

Steps to Reproduce

1. Create a custom link and add it to a group. Make the name use Jinja style code - example {% if True %} Custom Link 1{% endif %}
2. Open a device and look at the custom link

Expected Behavior

Expected the link to use the Jinja2 code and show "Custom Link 1" as name.

Observed Behavior

The Jinja code is shown as the name. So the name is "{% if True %} Custom Link 1{% endif %}" instead of "Custom Link 1". The link itself is also not rendering Jinja code.

This seems to come from #3461 and due to the text_rendered and link_rendered not being used in the format statement on

netbox/netbox/extras/templatetags/custom_links.py

Line 72 in b5455ed

GROUP_LINK.format(cl.url, link_target, cl.text)

I did a quick check and changed

                text_rendered = render_jinja2(cl.text, context)
                if text_rendered:
                    link_target = ' target="_blank"' if cl.new_window else ''
                    links_rendered.append(
                        GROUP_LINK.format(cl.url, link_target, cl.text)
                    )

to

                text_rendered = render_jinja2(cl.text, context)
                if text_rendered:
                    link_target = ' target="_blank"' if cl.new_window else ''
                    link_rendered = render_jinja2(cl.url, context)
                    links_rendered.append(
                        GROUP_LINK.format(link_rendered, link_target, text_rendered)
                    )

This made it work as expected again.

[hSaria]

Yeah, that seems to have been forgotten for grouped links. I'll raise a PR but you pretty much did all the work :)