Skip to content

Relax non-essential required fields when connecting #3902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
hSaria opened this issue Jan 13, 2020 · 0 comments · Fixed by #3903
Closed

Relax non-essential required fields when connecting #3902

hSaria opened this issue Jan 13, 2020 · 0 comments · Fixed by #3903
Labels
status: accepted This issue has been accepted for implementation type: housekeeping Changes to the application which do not directly impact the end user

Comments

@hSaria
Copy link
Contributor

hSaria commented Jan 13, 2020

Proposed Changes

Relax the non-essential required fields when connecting to a circuit terminations or a power feed (all other forms are fine).

Justification

THe circuit terminations' provider field is set to required, although not everyone needs it, like if you knew the circuit ID already. Similarly, connecting to a power feed shouldn't require site and power panel; they're only there to allow you to filter down the final list of power feeds.

This will replicate the behaviour of other ConnectCableTo forms.
@hSaria hSaria mentioned this issue Jan 13, 2020
Merged
@jeremystretch jeremystretch added status: accepted This issue has been accepted for implementation type: housekeeping Changes to the application which do not directly impact the end user labels Jan 13, 2020
jeremystretch added a commit that referenced this issue Jan 13, 2020
@jeremystretch
Merge pull request #3903 from hSaria/3902-relax-connect
b64f4b9 
Fixes #3902: relax non-essential required fields
@lock lock bot locked as resolved and limited conversation to collaborators Apr 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
status: accepted This issue has been accepted for implementation type: housekeeping Changes to the application which do not directly impact the end user
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes #3902: relax non-essential required fields
2 participants
@jeremystretch @hSaria