Skip to content

Add tests for all individual create/edit/delete object views #4000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jeremystretch opened this issue Jan 23, 2020 · 1 comment · Fixed by #4072
Closed

Add tests for all individual create/edit/delete object views #4000

jeremystretch opened this issue Jan 23, 2020 · 1 comment · Fixed by #4072
Assignees
@jeremystretch
Labels
status: accepted This issue has been accepted for implementation type: housekeeping Changes to the application which do not directly impact the end user

Comments

@jeremystretch
Copy link
Member

Proposed Changes

Extend tests/test_views.py within each app to add tests for the create, edit, and delete views for all apps.

Justification

There is currently no coverage for these views, and establishing tests for them will help mitigate many bugs.
@jeremystretch jeremystretch added status: accepted This issue has been accepted for implementation type: housekeeping Changes to the application which do not directly impact the end user labels Jan 23, 2020
@sdktr
Copy link
Contributor

sdktr commented Jan 29, 2020

housekeeping always +1

@jeremystretch jeremystretch self-assigned this Jan 30, 2020
@jeremystretch jeremystretch mentioned this issue Jan 31, 2020
Merged
jeremystretch added a commit that referenced this issue Jan 31, 2020
@jeremystretch
Merge pull request #4072 from netbox-community/4000-view-tests
ce081a6 
Closes #4000: Add tests for the create, edit, and delete views of all models
This was referenced Feb 3, 2020
Closed
Closed
Merged
@lock lock bot locked as resolved and limited conversation to collaborators May 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jeremystretch jeremystretch

Labels
status: accepted This issue has been accepted for implementation type: housekeeping Changes to the application which do not directly impact the end user
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Closes #4000: Add tests for the create, edit, and delete views of all models netbox-community/netbox
2 participants
@jeremystretch @sdktr