Skip to content

Add tests for Prefix and IPAddress ordering #4034

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
DanSheps opened this issue Jan 28, 2020 · 0 comments · Fixed by #4068
Closed

Add tests for Prefix and IPAddress ordering #4034

DanSheps opened this issue Jan 28, 2020 · 0 comments · Fixed by #4068
Assignees
@DanSheps
Labels
status: accepted This issue has been accepted for implementation type: housekeeping Changes to the application which do not directly impact the end user

Comments

@DanSheps
Copy link
Member

Proposed Changes

This issue is related to adding tests to ensure the data integrity of the Prefix and IPAddress model ordering behaviour.

This will add the following tests:

  • test_prefix_ordering
  • test_ipaddress_ordering
  • test_prefix-vrf_ordering
  • test_ipaddress-vrf_ordering
  • test_prefix_complex_ordering

The last test will be expected to have the ordering that results in a "problem" for #2562

Justification

This is tangently related to #2562 however the main goal is to ensure data integrity.
@DanSheps DanSheps added status: accepted This issue has been accepted for implementation type: housekeeping Changes to the application which do not directly impact the end user labels Jan 28, 2020
@DanSheps DanSheps self-assigned this Jan 28, 2020
DanSheps added a commit that referenced this issue Jan 29, 2020
@DanSheps
#4034 - Create tests for prefixes
084a68f
DanSheps added a commit that referenced this issue Jan 29, 2020
@DanSheps
#4034 - Create tests for addresses
22228b5
@DanSheps DanSheps mentioned this issue Jan 31, 2020
Merged
jeremystretch added a commit that referenced this issue Feb 12, 2020
@jeremystretch
Merge pull request #4068 from netbox-community/4034-prefix_ordering_t…
0c942f1 
…ests

Fixes: #4034 - Adds Prefix & IPAddress Ordering Tests
@lock lock bot locked as resolved and limited conversation to collaborators May 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@DanSheps DanSheps

Labels
status: accepted This issue has been accepted for implementation type: housekeeping Changes to the application which do not directly impact the end user
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes: #4034 - Adds Prefix & IPAddress Ordering Tests netbox-community/netbox
1 participant
@DanSheps