Skip to content

Override Django's management commands to suppress suggestion to create migrations #4051

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jeremystretch opened this issue Jan 30, 2020 · 0 comments · Fixed by #4053
Closed

Override Django's management commands to suppress suggestion to create migrations #4051

jeremystretch opened this issue Jan 30, 2020 · 0 comments · Fixed by #4053
Labels
status: accepted This issue has been accepted for implementation type: housekeeping Changes to the application which do not directly impact the end user

Comments

@jeremystretch
Copy link
Member

Proposed Changes

Alter or remove some of Django's built-in management commands to simplify the process of applying schema migrations for users. It might be best to introduce a "developers only" configuration parameter, and simply remove the makemigrations command from the list of available commands unless that parameter is set.

Justification

When a user does not follow the documented upgrade procedure, they may encounter a scenario where Django warns them of missing migrations, and prompts them to create new migrations. As this should never be required of an end user, we should remove that ability to help preserve the integrity of the installation environment.
@jeremystretch jeremystretch added status: accepted This issue has been accepted for implementation type: housekeeping Changes to the application which do not directly impact the end user labels Jan 30, 2020
jeremystretch added a commit that referenced this issue Jan 30, 2020
@jeremystretch
Closes #4051: Disable the makemigrations management command
4ba2579
@jeremystretch jeremystretch mentioned this issue Jan 30, 2020
Merged
jeremystretch added a commit that referenced this issue Jan 30, 2020
@jeremystretch
Merge pull request #4053 from netbox-community/4051-disable-makemigra…
316c0b6 
…tions

Closes #4051: Disable the makemigrations management command
@jeremystretch jeremystretch mentioned this issue Feb 4, 2020
Merged
@lock lock bot locked as resolved and limited conversation to collaborators May 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
status: accepted This issue has been accepted for implementation type: housekeeping Changes to the application which do not directly impact the end user
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Closes #4051: Disable the makemigrations management command netbox-community/netbox
1 participant
@jeremystretch