Skip to content

YAML rendering for config contexts with overlapping nested dictionary is incorrect #4150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
vsvetlov opened this issue Feb 12, 2020 · 2 comments · Fixed by #4155
Closed

YAML rendering for config contexts with overlapping nested dictionary is incorrect #4150

vsvetlov opened this issue Feb 12, 2020 · 2 comments · Fixed by #4155
Assignees
Labels
status: accepted This issue has been accepted for implementation type: bug A confirmed report of unexpected behavior in the application

Comments

@vsvetlov
Copy link

Environment

  • Python version: 3.7.3
  • NetBox version: 2.7.4

Steps to Reproduce

  1. Create config context region1
{
    "attributes": {
        "key10": "value10"
    }
}
  1. Create config context site1
{
    "attributes": {
        "key20": "value20"
    }
}
  1. These config contexts should be applied to the same device

Expected rendered context

attributes:
  key10: value10
  key20: value20

Observed rendered context

attributes: !!python/object/apply:collections.OrderedDict
- - - key10
    - value10
  - - key20
    - value20
@DanSheps DanSheps added status: accepted This issue has been accepted for implementation type: bug A confirmed report of unexpected behavior in the application labels Feb 12, 2020
@DanSheps
Copy link
Member

@hSaria I believe you did the YAML formatting, is this something you could look at?

@hSaria
Copy link
Contributor

hSaria commented Feb 12, 2020 via email

jeremystretch added a commit that referenced this issue Feb 12, 2020
Fixes #4150: Replace OrderedDict with Dict when rendering YAML
@lock lock bot locked as resolved and limited conversation to collaborators May 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: accepted This issue has been accepted for implementation type: bug A confirmed report of unexpected behavior in the application
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants