Skip to content

Caching utilizes webhooks configuration #4159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
DanSheps opened this issue Feb 13, 2020 · 0 comments · Fixed by #4162
Closed

Caching utilizes webhooks configuration #4159

DanSheps opened this issue Feb 13, 2020 · 0 comments · Fixed by #4162
Assignees
@DanSheps
Labels
status: accepted This issue has been accepted for implementation type: bug A confirmed report of unexpected behavior in the application

Comments

@DanSheps
Copy link
Member

Environment

  • Python version: 2.6
  • NetBox version: develop

Steps to Reproduce

  1. Configure a separate redis server for caching

Expected Behavior

The separate server is used

Observed Behavior

The redis server for WEBHOOKS is used

Technical details

In settings.py, redis for caching uses WEBHOOKS_REDIS instead of CACHING_REDIS

CACHING_REDIS = REDIS.get('caching', {})
CACHING_REDIS_HOST = WEBHOOKS_REDIS.get('HOST', 'localhost')
CACHING_REDIS_PORT = WEBHOOKS_REDIS.get('PORT', 6379)
CACHING_REDIS_PASSWORD = WEBHOOKS_REDIS.get('PASSWORD', '')
CACHING_REDIS_DATABASE = WEBHOOKS_REDIS.get('DATABASE', 0)
CACHING_REDIS_DEFAULT_TIMEOUT = WEBHOOKS_REDIS.get('DEFAULT_TIMEOUT', 300)
CACHING_REDIS_SSL = WEBHOOKS_REDIS.get('SSL', False)
@DanSheps DanSheps added type: bug A confirmed report of unexpected behavior in the application status: accepted This issue has been accepted for implementation labels Feb 13, 2020
@DanSheps DanSheps self-assigned this Feb 13, 2020
@DanSheps DanSheps changed the title Caching utilizes WEBHOOKS configuration Caching utilizes webhooks configuration Feb 13, 2020
DanSheps added a commit that referenced this issue Feb 13, 2020
@DanSheps
Fixes: #4159 - Corrects settings.py to use CACHING_REDIS instead of W…
617fc76 
…EBHOOKS_REDIS
@jeremystretch jeremystretch mentioned this issue Feb 13, 2020
Merged
@DanSheps DanSheps mentioned this issue Feb 13, 2020
Merged
jeremystretch added a commit that referenced this issue Feb 13, 2020
@jeremystretch
Merge pull request #4162 from netbox-community/4159-caching_redis_usi…
3e0ab79 
…ng_wrong_key

Fixes: #4159 - Corrects settings.py to use CACHING_REDIS
jeremystretch added a commit that referenced this issue Feb 13, 2020
@jeremystretch
Changelog for #4159
47b15aa
@jeremystretch jeremystretch mentioned this issue Feb 13, 2020
Merged
@lock lock bot locked as resolved and limited conversation to collaborators May 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@DanSheps DanSheps

Labels
status: accepted This issue has been accepted for implementation type: bug A confirmed report of unexpected behavior in the application
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes: #4159 - Corrects settings.py to use CACHING_REDIS netbox-community/netbox
1 participant
@DanSheps