822 bulk import of device components #3711
Conversation
3457 Display cable colors in device interface list
…nge-if-come-in-with-ldap-auth Hide password change page when user is logged in using LDAP
P3P is obsolete (https://www.w3.org/TR/P3P11/), therefore the HTTP header should be removed from the recommended config in the installation docs.
Docs: Remove obsolete P3P policy
Closes #3663: API filter by created, last_updated
fix url expressions
Fixes #3697: Correct field_order attribute name
|
This is looking good. I noticed several of your init methods have some duplicated logic. Do you think there is any way we can reduce some of that to make it more DRY? Also, you have some TODOs for URLs, should we wait to merge this until after that is complete and added here? |
|
I have thought about abstracting the logic in the init methods a bit, but although they are similar they are not identical. Creating a helper function/method would make the code more compact but possibly harder to read (although that is very personal). In short: i have a slight preference for leaving it as it is, but don't mind either way. I think it's ready to merge. One of the merges has to go first, and I don't think the order really matters as long as the URLs are put in place before 2.7 is released. |
Fixes: #822
This PR implements bulk import forms for device components. The only thing missing is a decent place to link to/from these import forms. I suggest adding those links after #3564 has been implemented. Those pages would be the perfect place for a link to the import.