-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Fixes 3803 #3804
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes 3803 #3804
Conversation
That's odd. Which platform (OS and web browser) are you on? I don't think I used anything new or special in the SVG, but perhaps I did. |
This is using Firefox on Linux Mint. I see the same thing when viewing the SVG code on JSFiddle. Edit: Renders correctly on Chrome. |
This looks relevant. |
|
This works on FireFox, though I'm gonna test it on other platforms too given the unknown support for |
I could just use
The downside is that changing the "font" won't be as easy as it would've gotten converted to a path. |
How about this? Had to play around, but got it working with the help of text-to-svg and some "finesse," if you will. TextToSVG = require('text-to-svg');
textToSVG = TextToSVG.loadSync('Avenir-Heavy-05.ttf');
console.log(textToSVG.getD('netbox', {fontSize: 200, anchor: 'top', letterSpacing: 0.02})); This should work everywhere as it's only built with circles, rectangles, and paths (all widely compatible). |
Can't say I have a strong opinion either way, so long as it's widely supported. I do like that the path approach ensures consistency regardless of installed fonts. |
Let's go with the path approach for now. We can always revert to the text approach later on if needed for some reason. |
Fixes: #3803
Replaced the current PNG logo (raster-based) with an SVG one (vector-based).