Skip to content

Fixes #3122: Select2 for device field #3826

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 2, 2020
Merged

Fixes #3122: Select2 for device field #3826

merged 4 commits into from
Jan 2, 2020

Conversation

hSaria
Copy link
Contributor

@hSaria hSaria commented Jan 2, 2020

Fixes: #3122

I didn't put this in the changelog because it's nothing notable

@jeremystretch
Copy link
Member

I've noticed an issue with this approach: After submitting the filter form, the object list comes back as expected however the field value is lost. This is due to searching by device name rather than ID. We should change device to device_id to remain consistent with the other filter forms/fields.

device_id exists on CableFilter and InventoryItemFilter however it needs to be added to the other three filter sets. I can take care of this in a separate FR.

@jeremystretch
Copy link
Member

Added the necessary device_id filters under #3827.

@hSaria
Copy link
Contributor Author

hSaria commented Jan 2, 2020 via email

@hSaria
Copy link
Contributor Author

hSaria commented Jan 2, 2020

The PR is ready now. I've also fixed up the Site select widgets for the 3 "something Connections".

I used device_id for the sake of #2669

@jeremystretch jeremystretch merged commit caa062c into netbox-community:develop Jan 2, 2020
@hSaria hSaria deleted the 3122-connection-device-select2 branch January 2, 2020 21:42
@lock lock bot locked as resolved and limited conversation to collaborators Apr 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use Select2 UI to filter cables by connected device
2 participants