Skip to content

Fixes #568: CSV import/export of custom fields #3885

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 18 commits into from
Jan 29, 2020
Merged

Fixes #568: CSV import/export of custom fields #3885

merged 18 commits into from
Jan 29, 2020

Conversation

hSaria
Copy link
Contributor

@hSaria hSaria commented Jan 10, 2020

Fixes: #568

Allows the custom fields to be imported and exported via CSV.

This is a refactor of the code @anthonyeden wrote in his original PR #2949; the credit goes to him.

@hSaria hSaria changed the title Fixed #568: CSV import/export of custom fields Fixes #568: CSV import/export of custom fields Jan 10, 2020
jeremystretch
jeremystretch requested changes Jan 23, 2020
View reviewed changes
Copy link
Member

@jeremystretch jeremystretch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In addition to above, we'll need to add tests for custom field import. IMO a single new test class somewhere under extras using the Site object as an example would be sufficient; no need to extend the CSV import test for every model.

@hSaria hSaria requested a review from jeremystretch January 23, 2020 20:30
jeremystretch
jeremystretch reviewed Jan 24, 2020
View reviewed changes
@hSaria
Copy link
Contributor Author

hSaria commented Jan 24, 2020

Added the test you requested (sorry for the delay; I completely forget about it).

@jeremystretch jeremystretch changed the base branch from develop to 568-customfield-csv-import January 29, 2020 15:11
@jeremystretch jeremystretch merged commit db3b450 into netbox-community:568-customfield-csv-import Jan 29, 2020
@hSaria hSaria deleted the 568-csv-import-cf branch January 29, 2020 15:27
@jeremystretch
Copy link
Member

I've merged this into 568-customfield-csv-import for now because I want to refactor some of the custom field bits before we merge it into develop.

@jeremystretch jeremystretch mentioned this pull request Jan 29, 2020
Merged
@lock lock bot locked as resolved and limited conversation to collaborators May 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jeremystretch jeremystretch jeremystretch requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hSaria @jeremystretch