Skip to content

Fixes #4010: Fixes IP addresses table when filtering interfaces #4022

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 28, 2020
Merged

Fixes #4010: Fixes IP addresses table when filtering interfaces #4022

merged 2 commits into from
Jan 28, 2020

Conversation

hSaria
Copy link
Contributor

@hSaria hSaria commented Jan 27, 2020

Fixes: #4010

The IP addresses table and its toggle were not being considered by the filter.

@jeremystretch
Copy link
Member

I've found a small problem:

  1. Apply an interface filter
  2. Uncheck "show IPs"
  3. Clear the interface filter

After doing so, the IP address re-appear and the button is left unchecked.

@hSaria
Copy link
Contributor Author

hSaria commented Jan 27, 2020

Thanks for spotting this. I've restricted the selector for the interfaces to only rows with the interface class and then added handling around the next row (IP addresses) if it's present.

@jeremystretch jeremystretch merged commit 12cf69f into netbox-community:develop Jan 28, 2020
@hSaria hSaria deleted the 4010-interface-ip-filter branch January 28, 2020 18:55
jeremystretch added a commit that referenced this pull request Jan 28, 2020
@jeremystretch jeremystretch mentioned this pull request Jan 28, 2020
@lock lock bot locked as resolved and limited conversation to collaborators May 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IP Addresses not shown on filtered Interface list
2 participants