Skip to content

Fixes #4025: Cable status class #4026

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 28, 2020
Merged

Fixes #4025: Cable status class #4026

merged 3 commits into from
Jan 28, 2020

Conversation

hSaria
Copy link
Contributor

@hSaria hSaria commented Jan 27, 2020 •
edited
Loading

Fixes: #4025

The cable's class was being derived incorrectly, thus always evaluating to success even when the status is planned (should be info).

In addition to the colors, the mark connected/planned was always evaluating to Mark planned even when it already is.

@jeremystretch jeremystretch merged commit e7ef142 into netbox-community:develop Jan 28, 2020
@hSaria hSaria deleted the 4025-cable-status-class branch January 28, 2020 18:56
@lock lock bot locked as resolved and limited conversation to collaborators May 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Different colours for "planned" and "connected" cables
2 participants
@hSaria @jeremystretch