Fixes #3507: Filtering IP by multiple devices #4075
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremystretch
requested changes
Feb 3, 2020
netbox/ipam/filters.py
Outdated
| method='filter_device', | ||
| field_name='pk', | ||
| device = django_filters.ModelMultipleChoiceFilter( | ||
| field_name='interface__device__name', |
There was a problem hiding this comment.
This does not account for IP addresses assigned to interfaces belonging to virtual chassis members, which is why the local filter_device() method was added. The filter/method need to be adapted to pass multiple values.
There was a problem hiding this comment.
Thanks the review, I will fix later.
There was a problem hiding this comment.
Enabled filtering virtual chassis members also.
kobayashi
force-pushed
the
3507-filter-by-devices
branch
from
3d9f374 to
d5c4a9d
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #3507
Filtering IP addresses by device id or device name