Skip to content

Closes #3799: Remove NaturalOrderingManager #4122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Feb 7, 2020
Merged

Closes #3799: Remove NaturalOrderingManager #4122

merged 11 commits into from
Feb 7, 2020

Conversation

jeremystretch
Copy link
Member

Fixes: #3799

  • Introduce NaturalOrderingField for storing pre-rendered natural ordering-friendly values on models
  • Introduce naturalize() and naturalize_interface() to handle generating values suitable for natural ordering
  • Add a NaturalOrderingField (_name) to the site, rack, and device models, as well as all device components and component templates
  • Extend schema migrations to automatically generate naturalized values for existing objects
  • Remove NaturalOrderingManager
  • Remove custom ordering logic from InterfaceManager

@jeremystretch jeremystretch merged commit 202a0a0 into develop Feb 7, 2020
@jeremystretch jeremystretch deleted the 3799-natural-ordering-field branch February 7, 2020 21:27
@lock lock bot locked as resolved and limited conversation to collaborators May 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove NaturalOrderingManager
1 participant
@jeremystretch