Skip to content

Closes #4108: Extraneous queryset evaluation by FilterChoiceFields #4128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Feb 10, 2020

Conversation

jeremystretch
Copy link
Member

Fixes: #4108

Improve FilterChoiceField so that it no longer forces the evaluation of available choices on page load. (Choices are populated on-demand via the APISelect widget.)

@jeremystretch jeremystretch merged commit 3da6f22 into develop Feb 10, 2020
@jeremystretch jeremystretch deleted the 4108-apiselect-performance branch February 10, 2020 15:26
@lock lock bot locked as resolved and limited conversation to collaborators May 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FilterChoiceField forces queryset evaluation despite rendering only a default choice
1 participant