Skip to content

Fixes #4083: Permit nullifying applicable choice fields via API requests #4133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 10, 2020
Merged

Fixes #4083: Permit nullifying applicable choice fields via API requests #4133

merged 1 commit into from
Feb 10, 2020

Conversation

jeremystretch
Copy link
Member

Fixes: #4083

Fix up our custom ChoiceField to correctly handle null values for model choice fields. allow_blank signifies whether a value is required, whereas allow_null controls whether null will be passed directly or converted to a string.

@jeremystretch jeremystretch merged commit a54fcda into develop Feb 10, 2020
@jeremystretch jeremystretch deleted the 4083-serializer-null-choices branch February 10, 2020 20:16
@lock lock bot locked as resolved and limited conversation to collaborators May 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unable to nullify choice fields via the API
1 participant
@jeremystretch