Open
Description
Bug description
After the introduction of dynamic filters in the global node filter, the node selectors in the various tabs behave differently from other facets and the placement of the node filter is not optimal. In some tabs the dynamic node filters are missing. With the exception of the Functions tab, the view of the nodes facet in the global nodes filter has been reused from the global node filter as-is.
- The
Included
andExcluded
pills take up a lot of horizontal space, causing them to be clipped on narrower windows (e.g. when using multiple browser screens next to each other) and are visually confusing. See also Feedback on global node filter with dynamic filters #946. - Facets counts are not shown on the nodes facet. I.e. number of alerts or events in their respective tabs.
- The nodes filter on the Alerts tab (and others) is all the way at the bottom and not expanded by default.
- Events without an associated node (e.g. agent and audit events) can no longer be selected. ([Bug]: Events without node are filtered out #955) Their facet counts do show as 0 and the items are grayed out. This is caused by the
nodes_ids
facet always being provided, even when no node was selected.
Expected behavior
- Remove the pills. For those views where the dynamic filters are there, the list of nodes gets shorted with the selections of those filters, so they serve no purpose. For the other views (e.g. Events), a facet count is more useful.
- Show facet counts.
- Expand the nodes filter, and consider putting it back up at the top again.
- Provide an empty list for
nodes_ids
in the API request.
Steps to reproduce
Screenshots
Error Logs
No response
Desktop
OS: Ubuntu 23.04
Browser: Firefox
Browser Version: 119.0b8
Additional context
Some notes:
- The dynamic node filters are missing on the Events tab, but this makes sense for now, as the events don't have host labels associated with them. Rendering facet counts would not work properly and that could be confusing. It is a bit of an inconsistency, though.
- If we want to de-emphasize nodes (pets vs. cattle) then the placement of the node filter at the bottom makes sense. In this case, we should do that consistently though. I.e. doing the same for the Events tab.
- It would be nice if we could have the pills of selected filters in every tab, just like on the Overview tab. Note that there is some visual jumping between having no filters and some filters.
- Dynamic filters applied at the global level should probably cause the resulting host labels in the tab filter to be filtered. E.g. if I select
_cloud_instance_region
and there are 22 nodes withunknown
and 39 withus-east-1
, selectingus-east-1
in the global filter should have theunknown
be dropped on the tab filter. - For consistency let's use the singular for all filters, so
Node
andHost label
.