Skip to content

Move some lines of code #1604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 1, 2020
Merged

Move some lines of code #1604

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 33 additions & 7 deletions packages/build/src/core/main.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,13 +80,17 @@ const build = async function(flags = {}) {
logs,
testOpts,
})

if (!dry) {
logBuildSuccess(logs)
const duration = endTimer(logs, buildTimer, 'Netlify Build')
await trackBuildComplete({ commandsCount, netlifyConfig, duration, siteInfo, telemetry, mode, testOpts })
}

await handleBuildSuccess({
commandsCount,
buildTimer,
netlifyConfig,
dry,
siteInfo,
telemetry,
mode,
logs,
testOpts,
})
return { success: true, logs }
} catch (error) {
await maybeCancelBuild({ error, api, deployId })
Expand Down Expand Up @@ -243,4 +247,26 @@ const runBuild = async function({
return { commandsCount, error, statuses }
}

// Logs and reports that a build successfully ended
const handleBuildSuccess = async function({
commandsCount,
buildTimer,
netlifyConfig,
dry,
siteInfo,
telemetry,
mode,
logs,
testOpts,
}) {
if (dry) {
return
}

logBuildSuccess(logs)

const duration = endTimer(logs, buildTimer, 'Netlify Build')
await trackBuildComplete({ commandsCount, netlifyConfig, duration, siteInfo, telemetry, mode, testOpts })
}

module.exports = build