Add build.edge_handlers configuration property
#1828
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ehmicky
added
project:edge-handlers-support
type: feature
This was referenced Sep 18, 2020
erezrokah
reviewed
Sep 20, 2020
| @@ -6,14 +6,24 @@ const { removeEmptyObject, removeEmptyArray } = require('./remove') | |||
|
|
|||
| // Make sure we are not printing secret values. Use an allow list. | |||
| const cleanupConfig = function({ | |||
| build: { base, command, commandOrigin, environment = {}, functions, ignore, processing, publish } = {}, | |||
| build: { base, command, commandOrigin, environment = {}, functions, edge_handlers, ignore, processing, publish } = {}, | |||
There was a problem hiding this comment.
Unrelated to this PR, but should we open an issue to change commandOrigin to command_origin?
Also, can we also return edge_handlers_output_dir (or something similar) to be used by the CLI?
Context netlify/cli#1244 (comment)
There was a problem hiding this comment.
For command_origin: #1834
For edge_handlers_output_dir, neither @netlify/config nor @netlify/build knows nor uses that constant. This is defined and used internally by the Edge handlers plugin at the moment. When it comes to making that plugin share the constant to Netlify CLI, I think this should be tracked in #1822 (comment).
erezrokah
approved these changes
Sep 20, 2020
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #1821
This PR adds a
build.edge_handlersconfiguration property.This property behaves exactly like
functionswhen it comes to file path resolution, validation, etc.