Add constants.EDGE_HANDLERS_DIST
#1830
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ehmicky
added
type: feature
mraerino
suggested changes
Sep 18, 2020
There was a problem hiding this comment.
i have a strong opinion that this constant should be the choice of the plugin, not of netlify-build.
we are using that constant in other contexts like
- uploading handlers from CLI
- running handlers locally via traffic mesh
it doesn't make sense to move setting this to netlify-build. it's not something we consider anyone to use from the outside right now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1822
This adds
constants.EDGE_HANDLERS_DIST. This is passed to Build plugins to locate where Edge handlers bundles are being output. Its value is always.netlify/edge-handlers(relative to the build directory).This PR includes an integration test.