feat: pass default config for resolveUpdatedConfig instead of cached config #5761
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request adds or modifies JavaScript ( |
lukasholzer
commented
Jul 11, 2024
| if (parsedCachedConfig !== undefined) { | ||
| // if we receive a defaultConfig (something the CLI can set for the runBuild with defaults) | ||
| // we need to invalidate the cached config | ||
| if (parsedCachedConfig !== undefined && opts.defaultConfig === undefined) { |
There was a problem hiding this comment.
@eduardoboucas this is the main change here that makes it possible
eduardoboucas
approved these changes
Jul 11, 2024
Co-authored-by: Eduardo Bouças <[email protected]>
added 2 commits
July 11, 2024 14:50
…s-instead-of-cached-config
…s-instead-of-cached-config
…s-instead-of-cached-config
lukasholzer
deleted the
feat/pass-default-config-for-config-mutations-instead-of-cached-config
branch
5 tasks
Merged
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 Thanks for submitting a pull request! 🎉
Summary
Needed for: https://linear.app/netlify/issue/CT-738/cli-should-use-framework-detection-and-install-runtime-for-build-and
Changing this PR https://github.com/netlify/build/pull/5735/files to use the
defaultConfiginstead of thecachedConfigAs config mutations are not applied in
@netlify/configif a cached config is passed:For us to review and ship your PR efficiently, please perform the following steps:
we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a typo or
something that`s on fire 🔥 (e.g. incident related), you can skip this step.
your code follows our style guide and passes our tests.
A picture of a cute animal (not mandatory, but encouraged)