Skip to content

fix: update DENO_VERSION_RANGE #5929

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Dec 11, 2024
Merged

fix: update DENO_VERSION_RANGE #5929

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
63dc1e8
Update DENO_VERSION_RANGE
mrstork Dec 6, 2024
fa3cf89
chore: update lower end of deno version range
mrstork Dec 9, 2024
a89a5b6
test: match deno ranges in tests to DENO_VERSION_RANGE
mrstork Dec 10, 2024
67ebec1
Merge branch 'main' into update-deno-version-range
mrstork Dec 11, 2024
17df558
fix: update comment with a link to buildbot
mrstork Dec 11, 2024
5402324
Merge branch 'main' into update-deno-version-range
mrstork Dec 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/workflow.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,11 +52,11 @@ jobs:
os: [ubuntu-latest, macOS-latest, windows-latest]
node-version: ['*']
# Must include the minimum deno version from the `DENO_VERSION_RANGE` constant in `node/bridge.ts`.
deno-version: ['v1.37.0', 'v1.44.4']
deno-version: ['v1.39.0', 'v1.46.3']
include:
- os: ubuntu-latest
node-version: '14.16.0'
deno-version: 'v1.44.4'
deno-version: 'v1.46.3'
fail-fast: false
steps:
# Increasing the maximum number of open files. See:
Expand Down Expand Up @@ -192,7 +192,7 @@ jobs:
- name: Setup Deno
uses: denoland/setup-deno@v1
with:
deno-version: v1.44.4
deno-version: v1.46.3
if: ${{ !steps.release-check.outputs.IS_RELEASE }}
- name: Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v4
Expand Down
9 changes: 4 additions & 5 deletions packages/edge-bundler/node/bridge.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,11 +13,10 @@ import { getBinaryExtension } from './platform.js'

const DENO_VERSION_FILE = 'version.txt'

// When updating DENO_VERSION_RANGE, ensure that the deno version installed in the
// build-image/buildbot does satisfy this range!
// We're pinning the range because of an issue with v1.45.0 of the Deno CLI:
// https://linear.app/netlify/issue/FRP-775/deno-cli-v1450-causing-issues
const DENO_VERSION_RANGE = '1.37.0 - 1.44.4'
// When updating DENO_VERSION_RANGE, ensure that the deno version
// on the netlify/buildbot build image satisfies this range!
// https://github.com/netlify/buildbot/blob/f9c03c9dcb091d6570e9d0778381560d469e78ad/build-image/noble/Dockerfile#L410
const DENO_VERSION_RANGE = '1.39.0 - 1.46.3'

type OnBeforeDownloadHook = () => void | Promise<void>
type OnAfterDownloadHook = (error?: Error) => void | Promise<void>
Expand Down
Loading