feat: allow jigsaw to be called with the build bot token #6096
Conversation
|
This pull request adds or modifies JavaScript ( |
…-authenticate-extensions-call
|
This pull request adds or modifies JavaScript ( |
packages/config/src/api/site_info.ts
Outdated
| getAccounts(api), | ||
| getAddons(api, siteId), | ||
| getIntegrations({ siteId, testOpts, offline, accountId }), | ||
| getIntegrations({ siteId, testOpts, offline, accountId, token, sendBuildBotTokenToJigsaw }), |
There was a problem hiding this comment.
Perhaps we pass along the whole featureFlags object down the chain?
Good or bad aside, this appears to be the pattern I'm seeing being used in general in this repo. I'm also thinking of the situation where you need to add another flag in for some reason, passing the object down means you don't need to make as many changes.
|
This pull request adds or modifies JavaScript ( |
…-authenticate-extensions-call
|
This pull request adds or modifies JavaScript ( |
…-authenticate-extensions-call
|
This pull request adds or modifies JavaScript ( |
khendrikse
deleted the
cpla-2459/use-extension-metadata-for-beh-and-authenticate-extensions-call
branch
🎉 Thanks for submitting a pull request! 🎉
Summary
This allows netlify config to call jigsaw using a new token
netlify-sdk-build-bot-token. This is behind the feature flagsend_build_bot_token_to_jigsaw.We also pass extensionMetaData to build event handlers. This will only be populated for extensions, so normal build-plugins will not receive this information.
All of this does the following:
For us to review and ship your PR efficiently, please perform the following steps:
we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a typo or
something that`s on fire 🔥 (e.g. incident related), you can skip this step.
your code follows our style guide and passes our tests.
A picture of a cute animal (not mandatory, but encouraged)