Skip to content

fix: use correct type when validating EF header regex #6602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 4, 2025
Merged

fix: use correct type when validating EF header regex #6602

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions packages/edge-bundler/node/validation/manifest/__snapshots__/index.test.ts.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,12 +188,12 @@ ENUM must be equal to one of the allowed values

exports[`route headers > should throw on invalid pattern format 1`] = `
[ManifestValidationError: Validation of Edge Functions manifest failed
FORMAT must match format "regexPattern"
TYPE must be string

15 | "x-custom-header": {
16 | "matcher": "regex",
> 17 | "pattern": "/^Bearer .+/"
| ^^^^^^^^^^^^^^ 👈🏽 format must match format "regexPattern"
> 17 | "pattern": {}
| ^^ 👈🏽 type must be string
18 | }
19 | }
20 | }]
Expand Down
4 changes: 2 additions & 2 deletions packages/edge-bundler/node/validation/manifest/index.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,7 +209,7 @@ describe('route headers', () => {
manifest.routes[0].headers = {
'x-custom-header': {
matcher: 'regex',
pattern: '^Bearer .+$',
pattern: 'Bearer .+',
},
}

Expand Down Expand Up @@ -254,7 +254,7 @@ describe('route headers', () => {
manifest.routes[0].headers = {
'x-custom-header': {
matcher: 'regex',
pattern: '/^Bearer .+/',
pattern: /^Bearer .+/,
},
}

Expand Down
1 change: 0 additions & 1 deletion packages/edge-bundler/node/validation/manifest/schema.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@ const headersSchema = {
properties: {
pattern: {
type: 'string',
format: 'regexPattern',
},
matcher: {
type: 'string',
Expand Down
Loading