Branded Install Message #324
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
do you mind taking out the |
|
We should talk more about the branding here, it goes against the branding doc I saw internally. I got ahead of myself. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- Summary
Currently, any output from dependencies is the only thing the user sees when installing this package:
It would be better if the most bold thing users see is some sort of success and branded install of the CLI. Working on another PR in hopes of suppressing that output as well.
Open to suggestions for what it looks like, just mostly getting something in first.
- Test plan
- Description for the changelog
Create branded install message with ascii art
- A picture of a cute animal (not mandatory but encouraged)
