fix: Don't show broken url if a site is undeployed #327
Conversation
| @@ -18,8 +18,9 @@ class SitesListCommand extends Command { | |||
| const siteInfo = { | |||
| id: site.id, | |||
| name: site.name, | |||
| ssl_url: site.ssl_url, | |||
| account_name: site.account_name | |||
There was a problem hiding this comment.
i need to doublecheck this as i lack context on this specific command but whats up with the rename of these props?
There was a problem hiding this comment.
site.ssl_url is always defined in the API, even if the site is not deployed.
I needed to check if site is deployed, so I used site.published_deploy; because published_deploy also contained ssl_url, I decided to use that instead of site.ssl_url
I'm not sure if they are the same though. An alternative approach would be to keep using site.ssl_url and only use published_deploy as a flag.
There was a problem hiding this comment.
oh man ok. thanks very much. i dont have bandwidth to look at this right now but appreciate the input and will need to come back to this to confirm that these are the right values.
There was a problem hiding this comment.
Hey, just fyi. There is one more case where cli output is broken — the site is deployed, but the recent build fails. It seems, that the API data doesn't contain any information about the recent broken build.
A possible solution might be to list the deployments for each site, and calculate status from there, but probably it's better to add the status of most recent build to the API.
In any case, this MR doesn't cover all use cases, so feel free to close.
There was a problem hiding this comment.
thank you. still very tied up here but will get to it eventually. hugely appreciate the PR though!
Show status and /deploys url instead.
zastavnitskiy
force-pushed
the
fix_undeployed_sites
branch
from
b4872a4 to
da70934
Compare
- Summary
netlify sites:listshows the wrong URL if a site is undeployed — the URL doesn't contain the hash of the deployment ↓Todo:
- Description for the changelog ↑
This MR only fixes the client. Instead of using site.ssl_url we will try to use last published deploy to check and display the correct URL.
Otherwise, display error status.
- Test plan
netlify sites:list