use a list of sites to chose from rather than entering the name manually #335
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
biilmann
reviewed
Jun 18, 2019
| @@ -132,25 +123,19 @@ Run ${chalk.cyanBright('`git remote -v`')} to see a list of your git remotes.`) | |||
| } | |||
|
|
|||
| if (sites.length === 0) { | |||
| context.error(`No sites found named ${siteName}`) | |||
| context.error(`You don't have any sites. Use netlify 'sites:create' to create a site.`) | |||
There was a problem hiding this comment.
At some point we could even consider letting the user pick a prompt to create a new site directly here.
There was a problem hiding this comment.
That's a great idea.
|
LGTM - have we tested on an account with lots of sites? |
|
@biilmann should be good with many sites: |
|
I don't think I'd count ~15 sites as "many". Some people have hundreds! |
|
best to use autocomplete/filter to handle many sites |
This was referenced Sep 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- Summary
netlify linkmakes you manually enter the name of your site, which may result in human error and a tedious process. I wanted to give users a list of sites so there's no human error involved.- Test plan
- Description for the changelog
Better DX for linking sites in
netlify link- A picture of a cute animal (not mandatory but encouraged)