Skip to content

Consider sites from different team in Netlify link #500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 9, 2019
Merged

Consider sites from different team in Netlify link #500

merged 3 commits into from
Sep 9, 2019

Conversation

RaeesBhatti
Copy link
Contributor

@RaeesBhatti RaeesBhatti commented Sep 1, 2019 •
edited
Loading

- Summary
Fixes: #498

Change listSites API calls to include filter: "all", so that, the link commands looks through all sites in different teams.

- Test plan

  • Clone a repo for a site in different team
  • Run netlify link
  • Choose any option

- Description for the changelog

  • Change listSites API call in Use a current git remote URL option to include filter: "all"
  • Change listSites API call in Choose from a list of your sites option to include filter: "all"
  • Use repoUrl instead of repoInfo.repo_path in error message

- A picture of a cute animal (not mandatory but encouraged)
GUEST_196b869e-4d84-4010-98b6-0b3e6dac4ff3

verythorough
verythorough approved these changes Sep 9, 2019
View reviewed changes
Copy link
Contributor

@verythorough verythorough left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works for me. 👍

@RaeesBhatti RaeesBhatti merged commit d3265fe into master Sep 9, 2019
@RaeesBhatti RaeesBhatti deleted the raees/link-fix branch September 9, 2019 21:16
@erezrokah erezrokah mentioned this pull request Aug 20, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@verythorough verythorough verythorough approved these changes

@jschatz1 jschatz1 Awaiting requested review from jschatz1

@DavidWells DavidWells Awaiting requested review from DavidWells

@swyxio swyxio Awaiting requested review from swyxio

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

netlify link doesn't recognize sites in different teams
2 participants
@RaeesBhatti @verythorough