-
Notifications
You must be signed in to change notification settings - Fork 393
feat: support granular context file setting #7284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Added `--skip-detection` flag to skip the automatic IDE detection and fallback to choice list.
d8480e8
to
5ebfa8f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want to add some tests here?
command: string | ||
consumerKey: string | null | ||
}> => { | ||
const { stdout } = await execa('ps', ['-p', String(pid), '-o', 'ppid=,comm=']) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What happens on Windows?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know, @smnh will need to verify. Currently, this work is all wrapped in try/catch and will skip if any errors are thrown and, if it simply doesn't work, then it will also continue as it does without this logic.
yes, working on those right now |
🎉 Thanks for submitting a pull request! 🎉
Summary
Docs has been refactored to provide granular context data: https://github.com/netlify/docs/pull/4352 - this needs to be deployed before this CLI version goes out.
This update to the recipe for ai context introduces a few changes:
All that to say, going forward, if we want to add a new consumer tool (like Sourcegraph's Amp) we just update the docs with the new consumer, assign the context files it will need, the path to put it in, etc. and this recipe will automatically pick it up without needing an update. The goal is that as we find more nuances to the consumer tools, their needs for files, etc. we can update those on the context hosting (docs) and we can move more quickly.
For us to review and ship your PR efficiently, please perform the following steps:
passes our tests.
A picture of a cute animal (not mandatory, but encouraged)