-
Notifications
You must be signed in to change notification settings - Fork 43
Conversation
WIP till I there are some tests on this. Also, this is going to be a really bad breaking change. |
Maybe we can do this without a breaking change, adding pagination as an array property? Kind of weird but would ease the pain. |
This still requires the pagination parameters to be added to open-api. This is also a breaking change, unfortunately.
Ok, I modified this to not be a breaking change. What do you think @DavidWells ? Also, the total value is blank because bitbaloon does not return I'm a little less satisfied with the shape, (adding a property to an array instead of returning an object), but it lets us add this without a breaking change, and it shares the same algorithm as micro-api-client. |
seems unobjectionable. but i have v little contextual knowledge to be of use here. |
I spoke with @DavidWells last week over DM. Sounds like we should have a chat this week about this. He suggested we aim for the ideal API shape. I agree, though I worry we'll never get around to it due to the pain / refactoring involved. If we take an iterative approach, (e.g. the array property), we could at least gain the benefit of this without jumping that hurdle now. But it would also increase the probability of never refactoring to get to the ideal shape. |
we never got around to this :( |
FWIW, this is a working solution. |
- Summary
This still requires the pagination parameters to be added to open-api.
- Test plan
We should have a test server and make sure we get the right shape back.
- Description for the changelog
Adds pagination data to paginated responses.