This repository was archived by the owner on Oct 20, 2022. It is now read-only.
feat!: change the main exported steps #253
Merged
+16
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ehmicky
added
the
type: feature
erezrokah
approved these changes
Jun 10, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the normalization + validation steps from the parsing logic.
Breaking change: this means consumers will now need to first use
parseFileRedirects()orparseConfigRedirects(), then usenormalizeRedirects()(which is now exported). This change is needed to integrate with@netlify/config.For convenience, an upcoming PR will add a new method
parseAllRedirects()which will perform all of:parseFileRedirects(),parseConfigRedirects(),mergeRedirects(),normalizeRedirects(). This method will be used by Netlify CLI. However, I would like to separate this from this PR, so that we can patch CLI incrementally and make this PR a clear major release / breaking changes.Also, this renames:
parseRedirectsFormat()->parseFileRedirects()parseNetlifyConfig()->parseConfigRedirects()