Skip to content
This repository was archived by the owner on Oct 20, 2022. It is now read-only.

Conversation

RaeesBhatti
Copy link
Contributor

@RaeesBhatti RaeesBhatti changed the title Add support YAML config Add support for YAML config Nov 6, 2019
@DavidWells
Copy link

We for sure need yml support nice work.

I think we need to consolidate and use @netlify/config everywhere so variables etc resolve correctly https://github.com/netlify/build/tree/master/packages/config

This is also true for in the CLI https://github.com/netlify/cli/blob/7ddd543fa131c2531c5861f8bdc049cabbe6e6f3/src/utils/command.js#L36

@RaeesBhatti
Copy link
Contributor Author

Should we implement using @netlify/config here now since we already implemented that in the CLI. Not sure how that affects this PR!

@DavidWells
Copy link

DavidWells commented Dec 6, 2019

Yeah for sure. The config parsing is happening 2 places right now

  1. inside cli base command https://github.com/netlify/cli/blob/master/src/utils/command.js#L39-L40
  2. inside netlify/build when netlify build cli command is run
  3. and this lib

The yaml/json/toml/etc is already parsed when this lib is used and the resolved object is this.netlify.config in the CLI

Perhaps this lib can use that already resolved object instead of trying to parse things again?

@DavidWells
Copy link

DavidWells commented Dec 6, 2019

Is this library used anywhere else other than the CLI?

Readme says this moved? https://github.com/netlify/netlify-redirect-parser#moved-into-the-cli

@RaeesBhatti RaeesBhatti merged commit 5ff098b into master Dec 20, 2019
@RaeesBhatti RaeesBhatti deleted the raees/yaml-parser branch December 20, 2019 10:29
@swyxio
Copy link

swyxio commented Dec 20, 2019

that readme was old. raees unmoved it. bad call to merge it in but we didnt forsee netlify build at the time

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

split out redirect parser to separate repo?
3 participants