chore: test with go 1.20 and cleanup tooling #444
Conversation
✅ Deploy Preview for open-api ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
github-actions
bot
added
the
type: chore
danez
removed
the
type: chore
.github/workflows/test.yml
Outdated
| @@ -33,10 +33,10 @@ jobs: | |||
| strategy: | |||
| matrix: | |||
| os: [ubuntu-latest, macOS-latest, windows-latest] | |||
| go_version: [1.17.x, 1.18.x, 1.19.x] | |||
| go_version: [1.17.x, 1.18.x, 1.19.x, 1.20.x] | |||
There was a problem hiding this comment.
i think you can remove 1.17 and maybe also 1.18 as i think it would be fine to support 2 recent versions only
| runs-on: ${{ matrix.os }} | ||
| steps: | ||
| - name: Install Go ${{ matrix.go }} | ||
| - name: Install Go ${{ matrix.go_version }} |
There was a problem hiding this comment.
Thanks to https://marketplace.visualstudio.com/items?itemName=GitHub.vscode-github-actions which also checks for errors.
| @@ -10,13 +10,9 @@ require ( | |||
| github.com/go-openapi/strfmt v0.19.11 | |||
| github.com/go-openapi/swag v0.19.12 | |||
| github.com/go-openapi/validate v0.20.0 | |||
| github.com/go-swagger/go-swagger v0.23.0 | |||
There was a problem hiding this comment.
i think you need to keep this dependency so that the go run for the go:generate instructions work.
the usual advice on how to do this is by creating a package called tools that has this:
package tools
import (
_ "github.com/go-swagger/go-swagger"
)There was a problem hiding this comment.
if go run pkg@version is used then the go module is compiled and run without it being installed or affecting the current module. That is what I did. If you prefer I can change that back to what you are suggesting.
There was a problem hiding this comment.
if
go run pkg@versionis used then the go module is compiled and run without it being installed or affecting the current module. That is what I did. If you prefer I can change that back to what you are suggesting.
ah good point. i'd prefer having it in go.mod so renovate can update it though
Added go 1.20 to the test matrix.
This gets rid of
gobin, as it is not needed anymore, insteadgo runcan be used. Alsorichgois removed (for fancy test output) because I haven't seen this in any of our other repos, and even the author recommends not using it :)I had to update
swagger-gofrom 0.23 to 0.24, because 0.23 wouldn't work withgo run. 0.24 introduces case-insensitive enums, hence the changes to the generated models. I tried updating to the latest version (0.30), but then all generated models are very different, if we want to update we should maybe do it in steps.Also remove the deprecated labeler job.
Fixes #416