fix: create symlink parent directory before creating symlink itself #1709

Skn0tt · 2024-02-14T13:39:32Z

🎉 Thanks for submitting a pull request! 🎉

Summary

Fixes netlify/cli#6106, https://linear.app/netlify/issue/COM-351/esm-dependencies-in-v2-functions-in-pnpm-repo-cause-crash-in-dev.

For includedFiles, we're recreating symlinks, sometimes in nested paths. Sometimes this breaks because the target directory doesn't exist. This PR fixes that by ensuring that a symlinks containing directory is created before the symlink itself is created.

For us to review and ship your PR efficiently, please perform the following steps:

Open a bug/issue before writing your code 🧑‍💻.
This ensures we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing
a typo or something that`s on fire 🔥 (e.g. incident related), you can skip this step.
Read the contribution guidelines 📖. This ensures your code follows our style guide and
passes our tests.
Update or add tests (if any source code was changed or added) 🧪
Update or add documentation (if features were changed or added) 📝
Make sure the status checks below are successful ✅

A picture of a cute animal (not mandatory, but encouraged)

github-actions · 2024-02-14T13:41:00Z

⏱ Benchmark results

Comparing with 9e82c5a

largeDepsEsbuild: 1.5s

⬇️ 0.43% decrease vs. 9e82c5a

^           1.5s    1.5s            1.5s            1.5s                    1.5s                          
│   1.4s    ┌──┐    ┌──┐    1.4s    ┌──┐    1.4s    ┌──┐    1.4s    1.4s    ┌──┐    1.4s    1.5s    1.5s  
│ ──┌──┐────┼──┼────┼──┼────┌──┐────┼──┼────┌──┐────┼──┼────┌──┐────┌──┐────┼──┼────┌──┐────┌──┐────┌──┐──
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
└───┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴──>
    T-12    T-11    T-10    T-9     T-8     T-7     T-6     T-5     T-4     T-3     T-2     T-1      T

Legend

T-30 (e151134): 1.4s
T-29 (f5fb309): 1.4s
T-28 (cff8955): 1.5s
T-27 (be424b2): 1.5s
T-26 (f146798): 1.4s
T-25 (c7901aa): 1.4s
T-24 (bc7b0b8): 1.5s
T-23 (81e451b): 1.4s
T-22 (daa74ff): 1.4s
T-21 (128b059): 1.4s
T-20 (f01af04): 1.5s
T-19 (44f2871): 1.4s
T-18 (a176e52): 1.5s
T-17 (897284e): 1.5s
T-16 (30703f8): 1.5s
T-15 (ec7bde9): 1.4s
T-14 (05b3c1a): 1.4s
T-13 (393b490): 1.5s
T-12 (abcba24): 1.4s
T-11 (1b10dd1): 1.5s
T-10 (46377da): 1.5s
T-9 (1a06dac): 1.4s
T-8 (8a3845d): 1.5s
T-7 (8ebae9d): 1.4s
T-6 (655f1a8): 1.5s
T-5 (64ee032): 1.4s
T-4 (f129ca1): 1.4s
T-3 (bd3bd46): 1.5s
T-2 (136119a): 1.4s
T-1 (9e82c5a): 1.5s
T (current commit): 1.5s

largeDepsNft: 5.8s

⬆️ 2.58% increase vs. 9e82c5a

^           5.8s    5.8s                                    5.7s            5.7s                    5.8s  
│   5.5s    ┌──┐    ┌──┐    5.6s            5.6s    5.5s    ┌──┐    5.5s    ┌──┐    5.4s    5.6s    ┌──┐  
│ ──┌──┐────┼──┼────┼──┼────┌──┐────5.3s────┌──┐────┌──┐────┼──┼────┌──┐────┼──┼────┌──┐────┌──┐────|▒▒|──
│   |  |    |  |    |  |    |  |    ┌──┐    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
└───┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴──>
    T-12    T-11    T-10    T-9     T-8     T-7     T-6     T-5     T-4     T-3     T-2     T-1      T

Legend

T-30 (e151134): 5.4s
T-29 (f5fb309): 5.4s
T-28 (cff8955): 5.5s
T-27 (be424b2): 5.8s
T-26 (f146798): 5.5s
T-25 (c7901aa): 5.5s
T-24 (bc7b0b8): 5.6s
T-23 (81e451b): 5.5s
T-22 (daa74ff): 5.4s
T-21 (128b059): 5.7s
T-20 (f01af04): 5.5s
T-19 (44f2871): 5.6s
T-18 (a176e52): 5.8s
T-17 (897284e): 5.5s
T-16 (30703f8): 5.5s
T-15 (ec7bde9): 5.5s
T-14 (05b3c1a): 5.5s
T-13 (393b490): 5.6s
T-12 (abcba24): 5.5s
T-11 (1b10dd1): 5.8s
T-10 (46377da): 5.8s
T-9 (1a06dac): 5.6s
T-8 (8a3845d): 5.3s
T-7 (8ebae9d): 5.6s
T-6 (655f1a8): 5.5s
T-5 (64ee032): 5.7s
T-4 (f129ca1): 5.5s
T-3 (bd3bd46): 5.7s
T-2 (136119a): 5.4s
T-1 (9e82c5a): 5.6s
T (current commit): 5.8s

largeDepsZisi: 10.7s

⬆️ 1.06% increase vs. 9e82c5a

^          10.7s                                                           10.9s                   10.7s  
│  10.1s    ┌──┐   10.6s   10.5s   10.5s   10.3s   10.4s   10.6s   10.4s    ┌──┐   10.2s   10.6s    ┌──┐  
│ ──┌──┐────┼──┼────┌──┐────┌──┐────┌──┐────┌──┐────┌──┐────┌──┐────┌──┐────┼──┼────┌──┐────┌──┐────|▒▒|──
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
└───┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴──>
    T-12    T-11    T-10    T-9     T-8     T-7     T-6     T-5     T-4     T-3     T-2     T-1      T

Legend

T-30 (e151134): 10.3s
T-29 (f5fb309): 10.4s
T-28 (cff8955): 10.5s
T-27 (be424b2): 10.6s
T-26 (f146798): 10.4s
T-25 (c7901aa): 10.5s
T-24 (bc7b0b8): 10.5s
T-23 (81e451b): 9.9s
T-22 (daa74ff): 10.3s
T-21 (128b059): 10.7s
T-20 (f01af04): 10.4s
T-19 (44f2871): 10.1s
T-18 (a176e52): 10.4s
T-17 (897284e): 10s
T-16 (30703f8): 10.2s
T-15 (ec7bde9): 10.4s
T-14 (05b3c1a): 10.5s
T-13 (393b490): 10.6s
T-12 (abcba24): 10.1s
T-11 (1b10dd1): 10.7s
T-10 (46377da): 10.6s
T-9 (1a06dac): 10.5s
T-8 (8a3845d): 10.5s
T-7 (8ebae9d): 10.3s
T-6 (655f1a8): 10.4s
T-5 (64ee032): 10.6s
T-4 (f129ca1): 10.4s
T-3 (bd3bd46): 10.9s
T-2 (136119a): 10.2s
T-1 (9e82c5a): 10.6s
T (current commit): 10.7s

…etlify/zip-it-and-ship-it#1709) * fix: don't swallow beginning of path * chore: add repro * fix: create link parent directory before creating link

Skn0tt added 3 commits February 14, 2024 14:36

fix: don't swallow beginning of path

7279113

chore: add repro

9b44309

fix: create link parent directory before creating link

e1f0061

Skn0tt self-assigned this Feb 14, 2024

Skn0tt requested a review from a team as a code owner February 14, 2024 13:39

eduardoboucas approved these changes Feb 14, 2024

View reviewed changes

Skn0tt merged commit db2f959 into main Feb 14, 2024

Skn0tt deleted the fix-symlink-copying branch February 14, 2024 13:41

token-generator-app bot mentioned this pull request Feb 14, 2024

chore(main): release 9.29.2 #1710

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix: create symlink parent directory before creating symlink itself #1709

fix: create symlink parent directory before creating symlink itself #1709

Uh oh!

Skn0tt commented Feb 14, 2024

Uh oh!

github-actions bot commented Feb 14, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

fix: create symlink parent directory before creating symlink itself #1709

fix: create symlink parent directory before creating symlink itself #1709

Uh oh!

Conversation

Skn0tt commented Feb 14, 2024

Summary

Uh oh!

github-actions bot commented Feb 14, 2024

⏱ Benchmark results

largeDepsEsbuild: 1.5s

largeDepsNft: 5.8s

largeDepsZisi: 10.7s

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants