Skip to content

Conversation

oguzhanunlu
Copy link
Contributor

@oguzhanunlu oguzhanunlu commented Nov 19, 2020

Hi @stevehu , I didn't create a dedicated issue for the commit. Please let me know if I should do so or if I can improve the docs update.

@codecov-io
Copy link

Codecov Report

Merging #346 (4108762) into master (6cb431f) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #346   +/-   ##
=========================================
  Coverage     69.86%   69.86%           
  Complexity      697      697           
=========================================
  Files            80       80           
  Lines          2741     2741           
  Branches        568      568           
=========================================
  Hits           1915     1915           
  Misses          612      612           
  Partials        214      214           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6cb431f...4108762. Read the comment docs.

@stevehu stevehu merged commit 8e663d0 into networknt:master Nov 20, 2020
@stevehu
Copy link
Contributor

stevehu commented Nov 20, 2020

@oguzhanunlu Thanks a lot for your help. I will release a new version once the other NPE issue is resolved.

@oguzhanunlu
Copy link
Contributor Author

Thanks @stevehu !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants