Skip to content

Conversation

kenwa
Copy link

@kenwa kenwa commented Oct 13, 2017

The original implementation supports schema's to be accessible either in http, http, file, etc.. This pull request adds the possibility to also refer to schema's present in the applications classpath.

Kenneth Waldenstrøm added 2 commits October 13, 2017 07:46
… related schema files that is only available in the classpath
@stevehu stevehu merged commit ef579d1 into networknt:master Oct 13, 2017
@stevehu
Copy link
Contributor

stevehu commented Oct 13, 2017

@kenwa Thanks for your help. It is a very nice feature to support loading schema from classpath.

@kenwa
Copy link
Author

kenwa commented Oct 18, 2017

Nice that you liked the feature :-) Just wanted to let you know that a bump of version number accidentally slipped into the PR. You should probably fix that one.

Any chance that you could create a new release of the library? That would make it possible for us to use that one instead of our forked variant.

@stevehu
Copy link
Contributor

stevehu commented Oct 18, 2017

@kenwa I have released 0.1.11 minutes ago. I think this is an very unique feature and we need to let other people to enjoy it. Could you please write a unit test case to show people how to use it? The test case can also prevent other PRs to break this feature in the future. Thanks a lot for your contribution.

@kenwa
Copy link
Author

kenwa commented Oct 23, 2017

@stevehu Great! Then we'll use that one instead :-)

I created a PR with a test case showing how to use the feature a few minutes ago.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants