Skip to content

Conversation

valfirst
Copy link
Contributor

@valfirst valfirst commented Feb 1, 2023

@valfirst valfirst force-pushed the improve-logging-performance branch from dc3b8ff to 3167d4f Compare February 1, 2023 16:45
@codecov-commenter
Copy link

Codecov Report

Merging #649 (3167d4f) into master (5645d56) will increase coverage by 0.11%.
The diff coverage is 41.66%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@             Coverage Diff              @@
##             master     #649      +/-   ##
============================================
+ Coverage     70.71%   70.83%   +0.11%     
  Complexity      985      985              
============================================
  Files           100      100              
  Lines          3732     3730       -2     
  Branches        780      779       -1     
============================================
+ Hits           2639     2642       +3     
+ Misses          818      816       -2     
+ Partials        275      272       -3     
Impacted Files Coverage Δ
...ain/java/com/networknt/schema/FormatValidator.java 91.30% <0.00%> (ø)
...in/java/com/networknt/schema/PatternValidator.java 34.92% <0.00%> (ø)
...main/java/com/networknt/schema/JsonMetaSchema.java 80.70% <33.33%> (ø)
...etworknt/schema/AdditionalPropertiesValidator.java 75.00% <100.00%> (+1.19%) ⬆️
...n/java/com/networknt/schema/BaseJsonValidator.java 73.33% <100.00%> (+1.43%) ⬆️
...n/java/com/networknt/schema/DateTimeValidator.java 86.66% <100.00%> (ø)
...n/java/com/networknt/schema/JsonSchemaFactory.java 79.89% <100.00%> (+0.97%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@stevehu stevehu merged commit 5b15c46 into networknt:master Feb 3, 2023
@stevehu
Copy link
Contributor

stevehu commented Feb 3, 2023

Makes perfect sense. Thanks a lot for your help.

@valfirst valfirst deleted the improve-logging-performance branch February 3, 2023 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants