Fix Issue #93 #134
Merged
Fix Issue #93 #134
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
In the long term (i.e. once nautobot/nautobot#16 is implemented) this would be better solved as a one-time task run specifically when the plugin is first installed. In the short term, you might be able to implement a lot of this via custom logic in a migrations script (i.e., so that when nautobot-server migrate is run after installing the plugin, you have a function that iterates over all existing Device records and creates corresponding OnboardingDevice records) at that time. Have you considered that possibility?
Other than that suggestion, this looks good to me!
mzbroch
force-pushed
the
mzb-develop-fix-93
branch
from
dc1f5c0 to
b4eada1
Compare
glennmatthews
approved these changes
Mar 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes issue #93
OnboardingDevice model instances are created as a part of onboarding process for devices created before ntc-netbox-plugin-onboarding installation. With the fix, template_content is rendered properly for re-onboarded devices.
Closes #93