Skip to content

Fixes #36 #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 21, 2020
Merged

Fixes #36 #37

merged 1 commit into from
May 21, 2020

Conversation

whitej6
Copy link

@whitej6 whitej6 commented May 21, 2020

Resolved issues with device model (DeviceType), vendor (Manufacturer) and device_role (DeviceRole) not being slugified.

@whitej6 whitej6 added the bug Something isn't working label May 21, 2020
@whitej6 whitej6 requested a review from dgarros May 21, 2020 02:42
@whitej6 whitej6 linked an issue May 21, 2020 that may be closed by this pull request
Invalid slug generation #36
Closed
dgarros
dgarros approved these changes May 21, 2020
View reviewed changes
Copy link
Contributor

@dgarros dgarros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @whitej6

@dgarros dgarros merged commit ddccf8c into networktocode:master May 21, 2020
@dgarros dgarros mentioned this pull request May 21, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@dgarros dgarros dgarros approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Invalid slug generation
2 participants
@whitej6 @dgarros