Add pre-commit #25
Open
Add pre-commit #25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Add pre-commit in requirements. |
|
You still need to enable the pre-commit app. It is not a GitHub action and not a requirement. |
DimitriPapadopoulos
force-pushed
the
pre-commit
branch
4 times, most recently
from
64ba371 to
9375035
Compare
This comment was marked as outdated.
This comment was marked as outdated.
DimitriPapadopoulos
force-pushed
the
pre-commit
branch
4 times, most recently
from
2c96fd8 to
b57760f
Compare
|
The Python 3.13 CI failure is caused by python-cffi/cffi#24 as far as I can see. |
|
Note that pre-commit.ci is available for open source repositories only: |
DimitriPapadopoulos
force-pushed
the
pre-commit
branch
from
dee0fda to
77fae7b
Compare
DimitriPapadopoulos
force-pushed
the
pre-commit
branch
from
77fae7b to
5d1c7e5
Compare
|
It is a mix with PR#37. |
|
Right. I'll remove this for now: - id: ruff-format |
DimitriPapadopoulos
force-pushed
the
pre-commit
branch
from
5d1c7e5 to
a7eaf7b
Compare
|
Removed anything not related to moving from Rebased. |
.github/workflows/linters.yml
Outdated
| - name: Lint with Ruff | ||
| uses: astral-sh/ruff-action@v3 | ||
| run: | | ||
| ruff check --output-format=github |
There was a problem hiding this comment.
File .github/workflows/linters.yml is almost useless as it is, it just checks that installation remains possible.
DimitriPapadopoulos
force-pushed
the
pre-commit
branch
5 times, most recently
from
769f561 to
e9f4815
Compare
- assorted pre-commit hooks - add ruff linter as a pre-commit hook - remove pycodestyle from GitHub Action
- trim trailing whitespace - fix end of files
DimitriPapadopoulos
force-pushed
the
pre-commit
branch
from
e9f4815 to
318ad4e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #15 and #24.
You will have to enable pre-commit for this repository: Settings > GitHub_Apps.