-
Notifications
You must be signed in to change notification settings - Fork 127
Langchain VectorStore error handling #1052
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦙 MegaLinter status: ✅ SUCCESS
See detailed report in MegaLinter reports |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop-ai-limited-preview-3 #1052 +/- ##
===============================================================
Coverage ? 81.64%
===============================================================
Files ? 192
Lines ? 20678
Branches ? 3611
===============================================================
Hits ? 16883
Misses ? 2760
Partials ? 1035 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor in the grand scheme of things but we need to call notice error and set the vector_store_id attribute on it so the error trace can be linked to the event and also check for the error trace in the tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
* Add vectorstore error handling * Update botocore tests. #1051 * Add vector_store_id to attrs * Add vector_store_id testing * Update tox tests for botocore tests
* Add vectorstore error handling * Update botocore tests. #1051 * Add vector_store_id to attrs * Add vector_store_id testing * Update tox tests for botocore tests
* Add vectorstore error handling * Update botocore tests. #1051 * Add vector_store_id to attrs * Add vector_store_id testing * Update tox tests for botocore tests
Overview
This PR adds error handling for Langchain's VectorStore.