Skip to content

Conversation

lrafeei
Copy link
Contributor

@lrafeei lrafeei commented Jan 30, 2024

Overview

This PR adds error handling for Langchain's VectorStore.

Copy link

github-actions bot commented Jan 30, 2024

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ PYTHON bandit 1 0 5.1s
✅ PYTHON black 9 0 0 1.13s
✅ PYTHON flake8 9 0 0.57s
✅ PYTHON isort 9 0 0 0.29s
✅ PYTHON pylint 9 0 4.15s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

@mergify mergify bot added the tests-failing Tests failing in CI. label Jan 30, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jan 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (develop-ai-limited-preview-3@b65dc36). Click here to learn what that means.

Additional details and impacted files
@@                       Coverage Diff                       @@
##             develop-ai-limited-preview-3    #1052   +/-   ##
===============================================================
  Coverage                                ?   81.64%           
===============================================================
  Files                                   ?      192           
  Lines                                   ?    20678           
  Branches                                ?     3611           
===============================================================
  Hits                                    ?    16883           
  Misses                                  ?     2760           
  Partials                                ?     1035           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hmstepanek hmstepanek marked this pull request as ready for review January 30, 2024 22:45
@hmstepanek hmstepanek requested a review from a team January 30, 2024 22:45
Copy link
Contributor

@hmstepanek hmstepanek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor in the grand scheme of things but we need to call notice error and set the vector_store_id attribute on it so the error trace can be linked to the event and also check for the error trace in the tests.

@lrafeei lrafeei requested a review from hmstepanek January 31, 2024 19:08
Copy link
Contributor

@hmstepanek hmstepanek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mergify mergify bot added the merge-conflicts Merge conflicts detected. label Jan 31, 2024
@mergify mergify bot removed the merge-conflicts Merge conflicts detected. label Jan 31, 2024
@hmstepanek hmstepanek merged commit acac4b3 into develop-ai-limited-preview-3 Jan 31, 2024
@hmstepanek hmstepanek deleted the vectorstore-error branch January 31, 2024 20:04
@mergify mergify bot removed the tests-failing Tests failing in CI. label Jan 31, 2024
hmstepanek pushed a commit that referenced this pull request Feb 23, 2024
* Add vectorstore error handling

* Update botocore tests. #1051

* Add vector_store_id to attrs

* Add vector_store_id testing

* Update tox tests for botocore tests
hmstepanek pushed a commit that referenced this pull request Feb 23, 2024
* Add vectorstore error handling

* Update botocore tests. #1051

* Add vector_store_id to attrs

* Add vector_store_id testing

* Update tox tests for botocore tests
hmstepanek pushed a commit that referenced this pull request Feb 23, 2024
* Add vectorstore error handling

* Update botocore tests. #1051

* Add vector_store_id to attrs

* Add vector_store_id testing

* Update tox tests for botocore tests
@umaannamalai umaannamalai added this to the v9.8.0 milestone Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants