Skip to content

Conversation

khpeet
Copy link
Contributor

@khpeet khpeet commented May 7, 2025

This PR adds support for the Camunda Pyzeebe Module

  • Tracing and useful metadata collection for ZybeeClient functions
  • Tracing and useful metadata for ZybeeWorker decorators - @worker.task / @router.task

Need help with writing some tests for this instrumentation though

@khpeet khpeet requested a review from a team as a code owner May 7, 2025 20:31
@mergify mergify bot added the tests-failing Tests failing in CI. label May 7, 2025
@codecov-commenter
Copy link

codecov-commenter commented May 7, 2025

Codecov Report

❌ Patch coverage is 82.66667% with 13 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.40%. Comparing base (500a6ef) to head (29eff65).

Files with missing lines Patch % Lines
newrelic/hooks/external_pyzeebe.py 82.19% 4 Missing and 9 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1385      +/-   ##
==========================================
- Coverage   81.43%   81.40%   -0.03%     
==========================================
  Files         210      211       +1     
  Lines       23875    23950      +75     
  Branches     3764     3782      +18     
==========================================
+ Hits        19442    19497      +55     
- Misses       3168     3177       +9     
- Partials     1265     1276      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@khpeet khpeet marked this pull request as draft May 7, 2025 21:06
@mergify mergify bot removed the tests-failing Tests failing in CI. label May 8, 2025
@khpeet khpeet requested a review from umaannamalai May 28, 2025 17:56
@mergify mergify bot added the tests-failing Tests failing in CI. label May 28, 2025
@khpeet khpeet requested a review from umaannamalai June 18, 2025 13:56
@mergify mergify bot added the merge-conflicts Merge conflicts detected. label Jun 18, 2025
@khpeet khpeet requested a review from umaannamalai July 25, 2025 17:12
@hmstepanek hmstepanek self-requested a review August 26, 2025 19:12
@hmstepanek hmstepanek marked this pull request as ready for review August 26, 2025 23:29
Copy link
Contributor

@hmstepanek hmstepanek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Posting a partial review-ran out of time for today but I'll review the tests tomorrow.

@khpeet khpeet requested a review from hmstepanek August 27, 2025 14:29
Copy link
Contributor

@hmstepanek hmstepanek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like this PR needs to be rebased onto the latest main. It looks like there's also some missing coverage so we need to add some more tests for the following:

  • For what was previously the if-statements at the top of the new hooks file (now they are calling that extract function) we need to add coverage for message_id under publish_message and resources under deploy_resource.
  • The background task creation else clause is missing coverage.

@mergify mergify bot removed the merge-conflicts Merge conflicts detected. label Sep 3, 2025
@khpeet khpeet requested a review from hmstepanek September 3, 2025 19:05
@mergify mergify bot removed the tests-failing Tests failing in CI. label Sep 4, 2025
Copy link
Contributor

@hmstepanek hmstepanek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, this looks really good now! I had one note about he resourceCount getting dropped and the only other thing I see in coverage now is we need a test to cover this line:
https://app.codecov.io/github/newrelic/newrelic-python-agent/commit/93d1520084d254e15c030b895972c73290856e9a#c9c66516ae9ada6bf1c147f9dda06069-R93
Basically create a test without a background_task decorator and expect no data present. There are examples of this in other instrumentation tests you can use as a reference.

@mergify mergify bot added the tests-failing Tests failing in CI. label Sep 15, 2025
@khpeet khpeet requested a review from hmstepanek September 15, 2025 14:26
Copy link
Contributor

@hmstepanek hmstepanek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Looks like we need to rebase onto latest again before merging.

Sync from upstream/main
@khpeet
Copy link
Contributor Author

khpeet commented Sep 16, 2025

Looks good. Looks like we need to rebase onto latest again before merging.

Merged upstream to fork - should be good now @hmstepanek !

@mergify mergify bot removed the tests-failing Tests failing in CI. label Sep 16, 2025
Copy link
Contributor

@umaannamalai umaannamalai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 thanks for your collaboration on this PR!

@hmstepanek hmstepanek enabled auto-merge (squash) September 18, 2025 22:01
@mergify mergify bot added the tests-failing Tests failing in CI. label Sep 18, 2025
@hmstepanek hmstepanek merged commit 5c62b43 into newrelic:main Sep 18, 2025
190 of 203 checks passed
@mergify mergify bot removed the tests-failing Tests failing in CI. label Sep 18, 2025
TimPansino added a commit that referenced this pull request Sep 19, 2025
* Enable coverage for motor instrumentation (#1487)

* Drop CI Image Build Caching (#1493)

* Add deprecation warning for modules (#1490)

* Add deprecation warning for modules

* Megalinter fixes

* Bump github/codeql-action in the github_actions group (#1492)

Bumps the github_actions group with 1 update: [github/codeql-action](https://github.com/github/codeql-action).


Updates `github/codeql-action` from 3.30.1 to 3.30.3
- [Release notes](https://github.com/github/codeql-action/releases)
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md)
- [Commits](github/codeql-action@f1f6e5f...192325c)

---
updated-dependencies:
- dependency-name: github/codeql-action
  dependency-version: 3.30.3
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: github_actions
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>

* Add Additional Delay to Test Startup Fixture (#1494)

* Add additional delay to test startup fixture

* Fix assertion error message

---------

Co-authored-by: Uma Annamalai <[email protected]>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>

* Temporarily remove pypy310 test from pymysql and aiomysql (#1501)

* Remove pymysql pypy310 test

* Remove aiomysql pypy310 test

* Falcon sanic testing fix (#1495)

* Remove unsupported Sanic from tests

* Remove unsupported Falcon from tests

---------

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>

* Camunda Pyzeebe Instrumentation (#1385)

* add initial pyzeebe instrumentation/tests

* second attempt at tests (failing)

* updated tests - 1/2 passing locally

* combine function_trace client tests

* fix: py agent team feedback #1

* fix: pyzeebe tests

* chore: ruff formatting

* fix: review updates #2

* fix: next round of updates

* fix: more updates based on feedback

* fix: resource parameter capture

* chore: ruff lint fixes

* fix: no txn tests;add resourceCount attr back

---------

Co-authored-by: Uma Annamalai <[email protected]>

* Format with ruff (#1505)

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: Timothy Pansino <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Co-authored-by: Uma Annamalai <[email protected]>
Co-authored-by: Keagan Peet <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants